Swift - GeoFire removeObserver Not Working, seeking for workaround please

145 views Asked by At

I find out that both removeObserver and .removeAllObservers() is not working in GeoFire, hoping another work around to "get out" of this observe (which keeps loading forever)

var newRefHandle: FIRDatabaseHandle?
var gFCircleQuery: GFCircleQuery?

func findFUsersInOnePath(location: CLLocation,
                         radius: Int,
                         indexPath: String,
                         completion: @escaping () -> ()){
    var ids = 0
    let geofireRef = usersRef.child(indexPath)
    if let geoFire = GeoFire(firebaseRef: geofireRef) {
        gFCircleQuery = geoFire.query(at: location, withRadius: Double(radius))
        newRefHandle = gFCircleQuery?.observe(.keyEntered, with: { (key, location) in
            // if key fit some condition then perform some other firebase call to other database(async), afterwards:
            ids += 1
            if (ids >= 3) {
                //RemoveObersver not working below...
                self.gFCircleQuery?.removeObserver(withFirebaseHandle: self.newRefHandle!)
                completion()
            }
        })
        //I find that observeReady gets call right away despite we haven't complete  code above 
        gFCircleQuery?.observeReady({
            completion()
        })
}
1

There are 1 answers

6
Frank van Puffelen On

My guess is that you're still getting some .keyEntered events after the call to removeObserver, which is actually to be expected.

GeoFire performs a single query to get all keys within the range for your query, and then calls your .keyEntered callback for each of these keys. Even if you call removeObserver for the first key, GeoFire will continue to call the .keyEntered callback with the remainder of the keys that it already got from the database.

For this reason, I'd recommend removing the observer inside the ready block for the query. The behavior will not change when you do that, but it'll make more sense as that ready block is called when GeoFire is done telling you about the batch of keys.